From: Jihoon Kim <jihoon48.kim@samsung.com>
Date: Wed, 17 Jan 2018 01:45:37 +0000 (+0900)
Subject: Fix potential memory leak issue when setting invocation name several times
X-Git-Tag: accepted/tizen/unified/20180228.071746~14
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0712d0482ca8e93485064dd96b49a947eda7e266;p=platform%2Fcore%2Fuifw%2Fvoice-control.git

Fix potential memory leak issue when setting invocation name several times

Change-Id: I5de2aed2bd97e571b3c0fc60b81ad7993f17ac9e
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
---

diff --git a/client/vc_client.c b/client/vc_client.c
index 2602c1a..cb7be34 100644
--- a/client/vc_client.c
+++ b/client/vc_client.c
@@ -494,12 +494,13 @@ int vc_client_set_invocation_name(vc_h vc, const char* invocation_name)
 	if (NULL == client)
 		return VC_ERROR_INVALID_PARAMETER;
 
+	if (NULL != client->invocation_name)
+		free(client->invocation_name);
+
+	client->invocation_name = NULL;
+
 	if (NULL != invocation_name) {
 		client->invocation_name = strdup(invocation_name);
-	} else {
-		if (NULL != client->invocation_name)
-			free(client->invocation_name);
-		client->invocation_name = NULL;
 	}
 	return 0;
 }