From: Dan Carpenter Date: Sat, 17 Aug 2019 06:55:20 +0000 (+0300) Subject: usb: host: ohci-pxa27x: Fix and & vs | typo X-Git-Tag: v5.4-rc1~136^2~51 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0709831a50d31b3caf2237e8d7fe89e15b0d919d;p=platform%2Fkernel%2Flinux-rpi.git usb: host: ohci-pxa27x: Fix and & vs | typo The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's a no-op because of the & vs | typo. This bug predates git and it was only discovered using static analysis so it must not affect too many people in real life. Signed-off-by: Dan Carpenter Acked-by: Alan Stern Link: https://lore.kernel.org/r/20190817065520.GA29951@mwanda Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c index 3e24749..7679fb5 100644 --- a/drivers/usb/host/ohci-pxa27x.c +++ b/drivers/usb/host/ohci-pxa27x.c @@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) uhcrhda |= RH_A_NPS; break; case PMM_GLOBAL_MODE: - uhcrhda &= ~(RH_A_NPS & RH_A_PSM); + uhcrhda &= ~(RH_A_NPS | RH_A_PSM); break; case PMM_PERPORT_MODE: uhcrhda &= ~(RH_A_NPS);