From: Justin Lebar <jlebar@google.com>
Date: Tue, 29 May 2018 18:19:19 +0000 (-0700)
Subject: [XLA] Clarify that options passed to LocalService override legacy_flags values.
X-Git-Tag: upstream/v1.9.0_rc1~38^2~4^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=06fd5e9cfb56725c998aae90940154511411342d;p=platform%2Fupstream%2Ftensorflow.git

[XLA] Clarify that options passed to LocalService override legacy_flags values.

PiperOrigin-RevId: 198426696
---

diff --git a/tensorflow/compiler/xla/client/local_client.h b/tensorflow/compiler/xla/client/local_client.h
index d63d4ec..3f23e52 100644
--- a/tensorflow/compiler/xla/client/local_client.h
+++ b/tensorflow/compiler/xla/client/local_client.h
@@ -58,12 +58,18 @@ class LocalExecutable {
 
   // Validates that the given arguments and options satisfy various constraints
   // of the computation.
+  //
+  // The given ExecutableRunOptions override any values from legacy_flags
+  // (TF_XLA_FLAGS environment variable).
   Status ValidateExecutionOptions(
       const tensorflow::gtl::ArraySlice<const ShapedBuffer*> arguments,
       const ExecutableRunOptions& run_options, const Backend& backend);
 
   // Records the computation in a SessionModule proto with the arguments used to
   // invoke it, and the result. Enabled by flag: --tla_dump_executions_to.
+  //
+  // The given ServiceExecutableRunOptions override any values from legacy_flags
+  // (TF_XLA_FLAGS environment variable).
   StatusOr<ScopedShapedBuffer> ExecuteAndDump(
       const ServiceExecutableRunOptions* run_options,
       const tensorflow::gtl::ArraySlice<const ShapedBuffer*> arguments);
@@ -109,6 +115,9 @@ class LocalClient : public Client {
 
   // Build and return a LocalExecutable object. The executable is compiled using
   // the given XlaComputation, argument layouts and options.
+  //
+  // The given ExecutableBuildOptions override any values from legacy_flags
+  // (TF_XLA_FLAGS environment variable).
   StatusOr<std::unique_ptr<LocalExecutable>> Compile(
       const XlaComputation& computation,
       const tensorflow::gtl::ArraySlice<const Shape*> argument_layouts,