From: Markus Elfring Date: Sat, 14 Nov 2015 21:00:27 +0000 (+0100) Subject: Bluetooth: Delete an unnecessary check before the function call "kfree_skb" X-Git-Tag: v4.14-rc1~3609^2~588^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=06fbb3d5c7ff366fe7ab7b4157bdb3096fca6d09;p=platform%2Fkernel%2Flinux-rpi.git Bluetooth: Delete an unnecessary check before the function call "kfree_skb" The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Marcel Holtmann --- diff --git a/net/bluetooth/cmtp/core.c b/net/bluetooth/cmtp/core.c index 298ed37..9e59b66 100644 --- a/net/bluetooth/cmtp/core.c +++ b/net/bluetooth/cmtp/core.c @@ -178,8 +178,7 @@ static inline int cmtp_recv_frame(struct cmtp_session *session, struct sk_buff * cmtp_add_msgpart(session, id, skb->data + hdrlen, len); break; default: - if (session->reassembly[id] != NULL) - kfree_skb(session->reassembly[id]); + kfree_skb(session->reassembly[id]); session->reassembly[id] = NULL; break; }