From: Roland Dreier Date: Thu, 30 Aug 2012 23:28:30 +0000 (-0700) Subject: target/iscsi: Don't log "iSCSI Login negotiation failed." twice X-Git-Tag: v4.14-rc1~11097^2~32 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=06cda529d27d778f55690d5b09af8ae4448e796b;p=platform%2Fkernel%2Flinux-rpi.git target/iscsi: Don't log "iSCSI Login negotiation failed." twice There's no need for iscsi_target_init_negotiation() to print iSCSI Login negotiation failed. on failure, since its only caller (__iscsi_target_login_thread()) prints exactly the same message if it gets an error return back. Signed-off-by: Roland Dreier Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 2dba448cac19..a9a73ac88fd0 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -1000,7 +1000,6 @@ struct iscsi_login *iscsi_target_init_negotiation( * Locates Target Portal from NP -> Target IQN */ if (iscsi_target_locate_portal(np, conn, login) < 0) { - pr_err("iSCSI Login negotiation failed.\n"); goto out; }