From: Damian Hobson-Garcia Date: Wed, 22 Jun 2011 07:46:25 +0000 (+0000) Subject: fbdev: sh_mobile_meram: Correct pointer check for YCbCr chroma plane X-Git-Tag: v3.0-rc6~3^2~4^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=06c8a6a3e40265ff580428bbf51991617477f65b;p=profile%2Fivi%2Fkernel-x86-ivi.git fbdev: sh_mobile_meram: Correct pointer check for YCbCr chroma plane The check was intended to test if we have a valid pointer to write into, but it mistakenly checks the pointer contents instead. Since a valid pointer is mandatory for the chroma data if a YCbCr format is used, the pointer check has been removed. Signed-off-by: Damian Hobson-Garcia Signed-off-by: Paul Mundt --- diff --git a/drivers/video/sh_mobile_meram.c b/drivers/video/sh_mobile_meram.c index 9170c82..cc7d732 100644 --- a/drivers/video/sh_mobile_meram.c +++ b/drivers/video/sh_mobile_meram.c @@ -218,7 +218,7 @@ static inline void meram_get_next_icb_addr(struct sh_mobile_meram_info *pdata, icb_offset = 0xc0000000 | (cfg->current_reg << 23); *icb_addr_y = icb_offset | (cfg->icb[0].marker_icb << 24); - if ((*icb_addr_c) && is_nvcolor(cfg->pixelformat)) + if (is_nvcolor(cfg->pixelformat)) *icb_addr_c = icb_offset | (cfg->icb[1].marker_icb << 24); }