From: Craig Topper Date: Sat, 28 Oct 2017 23:10:13 +0000 (+0000) Subject: [X86] Remove invalid code from LowerVSELECT. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0692ca4bd2c41340a559df600c92a48a97953c54;p=platform%2Fupstream%2Fllvm.git [X86] Remove invalid code from LowerVSELECT. This code attempted to say that v8i16/v16i16 VSELECT is legal if BWI and VLX are enabled, but the only way we could reach this point is if the condition was not a vXi1 type. Which means it really wasn't legal. We don't have any tests that exercise this code. So I'm hoping it wasn't really reachable. llvm-svn: 316851 --- diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 0b36158..900c99b 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -14232,10 +14232,6 @@ SDValue X86TargetLowering::LowerVSELECT(SDValue Op, SelectionDAG &DAG) const { case MVT::v8i16: case MVT::v16i16: - // AVX-512 BWI and VLX features support VSELECT with i16 elements. - if (Subtarget.hasBWI() && Subtarget.hasVLX()) - return Op; - // FIXME: We should custom lower this by fixing the condition and using i8 // blends. return SDValue();