From: Munkyu Im Date: Fri, 16 Jan 2015 03:03:53 +0000 (+0900) Subject: emuld: Fix contextual warnings X-Git-Tag: submit/tizen/20150527.025434^2~10^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0686029d4633da62b1ec263ea5849bc13056db8f;p=platform%2Fadaptation%2Femulator%2Femulator-daemon.git emuld: Fix contextual warnings Change-Id: Iff8d7636d3cb0002ea00db3cdfc23bbe2836bff7 Signed-off-by: Munkyu Im --- diff --git a/packaging/emuld.spec b/packaging/emuld.spec index f3ee963..4079b08 100644 --- a/packaging/emuld.spec +++ b/packaging/emuld.spec @@ -1,5 +1,5 @@ Name: emuld -Version: 0.8.3 +Version: 0.8.4 Release: 0 Summary: Emulator daemon License: Apache-2.0 diff --git a/src/common_dev.cpp b/src/common_dev.cpp index 979f247..bd90fe6 100644 --- a/src/common_dev.cpp +++ b/src/common_dev.cpp @@ -54,7 +54,7 @@ static pthread_mutex_t mutex_cmd = PTHREAD_MUTEX_INITIALIZER; // HDS #define IJTYPE_HDS "hds" -char SDpath[256]; +char SDpath[512]; // Location #define STATUS 15 @@ -298,7 +298,7 @@ void msgproc_sdcard(const int sockfd, ijcommand* ijcmd) { memset(SDpath, '\0', sizeof(SDpath)); ret = strtok(NULL, token); - strncpy(SDpath, ret, strlen(ret)); + strncpy(SDpath, ret, sizeof(SDpath) -1); LOGDEBUG("sdcard path is %s", SDpath); mount_param* param = new mount_param(sockfd); @@ -532,6 +532,8 @@ static void* getting_location(void* data) char* msg = 0; LXT_MESSAGE* packet = (LXT_MESSAGE*)malloc(sizeof(LXT_MESSAGE)); + if (packet == NULL) + return 0; switch(param->ActionID) { @@ -577,9 +579,7 @@ static void* getting_location(void* data) free(msg); msg = 0; } - if (packet != NULL) { - free(packet); - } + free(packet); if (param) delete param;