From: Su Hui <suhui@nfschina.com>
Date: Mon, 20 Nov 2023 09:55:26 +0000 (+0800)
Subject: misc: mei: client.c: fix problem of return '-EOVERFLOW' in mei_cl_write
X-Git-Tag: v6.1.68~55
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=066dcd87b94cfe2b3bf307362756d6d2f693fa9d;p=platform%2Fkernel%2Flinux-starfive.git

misc: mei: client.c: fix problem of return '-EOVERFLOW' in mei_cl_write

[ Upstream commit ee6236027218f8531916f1c5caa5dc330379f287 ]

Clang static analyzer complains that value stored to 'rets' is never
read.Let 'buf_len = -EOVERFLOW' to make sure we can return '-EOVERFLOW'.

Fixes: 8c8d964ce90f ("mei: move hbuf_depth from the mei device to the hw modules")
Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20231120095523.178385-2-suhui@nfschina.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index 77501e3..c70c892 100644
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -2002,7 +2002,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb)
 
 	hbuf_slots = mei_hbuf_empty_slots(dev);
 	if (hbuf_slots < 0) {
-		rets = -EOVERFLOW;
+		buf_len = -EOVERFLOW;
 		goto out;
 	}