From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sat, 20 Feb 2016 22:30:29 +0000 (+0300)
Subject: at76c50x-usb: avoid double usb_put_dev() after downloading internal firmware in at76_... 
X-Git-Tag: v4.9.8~2476^2~79^2~16
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=064b32f822afd9a578a4ec6bf754cd61cbe0c324;p=platform%2Fkernel%2Flinux-rpi3.git

at76c50x-usb: avoid double usb_put_dev() after downloading internal firmware in at76_probe()

There is no need in usb_put_dev() if at76_load_internal_fw() succeed.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
---

diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
index dab2513..1efb1d6 100644
--- a/drivers/net/wireless/atmel/at76c50x-usb.c
+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -2481,9 +2481,7 @@ static int at76_probe(struct usb_interface *interface,
 			dev_err(&interface->dev,
 				"error %d downloading internal firmware\n",
 				ret);
-			goto exit;
 		}
-		usb_put_dev(udev);
 		goto exit;
 	}