From: Richard Earnshaw Date: Mon, 17 Sep 2012 17:43:42 +0000 (+0000) Subject: 2012-09-17 Yufeng Zhang X-Git-Tag: sid-snapshot-20121001~128 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=062f38fa2f1dc0acb90fddd948d87b1d34809d86;p=platform%2Fupstream%2Fbinutils.git 2012-09-17 Yufeng Zhang * aarch64-asm.c (aarch64_ins_imm_half): Remove ATTRIBUTE_UNUSED from the parameter 'inst'. (aarch64_ins_addr_simm): Add ATTRIBUTE_UNUSED to the parameter 'inst'. (convert_mov_to_movewide): Change to assert (0) when aarch64_wide_constant_p returns FALSE. --- diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 102f5df..ab543ca 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,11 @@ +2012-09-17 Yufeng Zhang + + * aarch64-asm.c (aarch64_ins_imm_half): Remove ATTRIBUTE_UNUSED from + the parameter 'inst'. + (aarch64_ins_addr_simm): Add ATTRIBUTE_UNUSED to the parameter 'inst'. + (convert_mov_to_movewide): Change to assert (0) when + aarch64_wide_constant_p returns FALSE. + 2012-09-14 David Edelsohn * configure: Regenerate. diff --git a/opcodes/aarch64-asm.c b/opcodes/aarch64-asm.c index e10240a..006b075 100644 --- a/opcodes/aarch64-asm.c +++ b/opcodes/aarch64-asm.c @@ -336,8 +336,7 @@ aarch64_ins_imm (const aarch64_operand *self, const aarch64_opnd_info *info, MOVZ , #{, LSL #}. */ const char * aarch64_ins_imm_half (const aarch64_operand *self, const aarch64_opnd_info *info, - aarch64_insn *code, - const aarch64_inst *inst ATTRIBUTE_UNUSED) + aarch64_insn *code, const aarch64_inst *inst) { /* imm16 */ aarch64_ins_imm (self, info, code, inst); @@ -532,7 +531,8 @@ aarch64_ins_addr_regoff (const aarch64_operand *self ATTRIBUTE_UNUSED, const char * aarch64_ins_addr_simm (const aarch64_operand *self, const aarch64_opnd_info *info, - aarch64_insn *code, const aarch64_inst *inst) + aarch64_insn *code, + const aarch64_inst *inst ATTRIBUTE_UNUSED) { int imm; @@ -1090,8 +1090,9 @@ convert_mov_to_movewide (aarch64_inst *inst) } inst->operands[1].type = AARCH64_OPND_HALF; is32 = inst->operands[0].qualifier == AARCH64_OPND_QLF_W; - /* This should have been guaranteed by the constraint check. */ - assert (aarch64_wide_constant_p (value, is32, &shift_amount) == TRUE); + if (! aarch64_wide_constant_p (value, is32, &shift_amount)) + /* The constraint check should have guaranteed this wouldn't happen. */ + assert (0); value >>= shift_amount; value &= 0xffff; inst->operands[1].imm.value = value;