From: Markus Armbruster Date: Wed, 31 Jul 2013 13:11:06 +0000 (+0200) Subject: exec: Clean up fall back when -mem-path allocation fails X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.1~524^2~3^2~168 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0628c18267bbe8d44f0faf3e71acf0ae31bea7fd;p=sdk%2Femulator%2Fqemu.git exec: Clean up fall back when -mem-path allocation fails With -mem-path, qemu_ram_alloc_from_ptr() first tries to allocate accordingly, but when it fails, it falls back to normal allocation. The fall back allocation code used to be effectively identical to the "-mem-path not given" code, until it started to diverge in commit 432d268. I believe the code still works, but clean it up anyway: drop the special fall back allocation code, and fall back to the ordinary "-mem-path not given" code instead. Reviewed-by: Paolo Bonzini Signed-off-by: Markus Armbruster Acked-by: Laszlo Ersek Acked-by: Stefano Stabellini Message-id: 1375276272-15988-3-git-send-email-armbru@redhat.com Signed-off-by: Anthony Liguori --- diff --git a/exec.c b/exec.c index da1d388297..482dd801df 100644 --- a/exec.c +++ b/exec.c @@ -1117,15 +1117,12 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host, if (mem_path) { #if defined (__linux__) && !defined(TARGET_S390X) new_block->host = file_ram_alloc(new_block, size, mem_path); - if (!new_block->host) { - new_block->host = qemu_anon_ram_alloc(size); - memory_try_enable_merging(new_block->host, size); - } #else fprintf(stderr, "-mem-path option unsupported\n"); exit(1); #endif - } else { + } + if (!new_block->host) { if (kvm_enabled()) { /* some s390/kvm configurations have special constraints */ new_block->host = kvm_ram_alloc(size);