From: Hyunil Park Date: Fri, 23 Aug 2019 06:33:14 +0000 (+0000) Subject: Revert "use-tbm is set to true when the condition is true" X-Git-Tag: submit/tizen/20190823.063831^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0619f8918582e81642a03aba37ff3d3dd65b4322;p=platform%2Fcore%2Fmultimedia%2Flibmm-player.git Revert "use-tbm is set to true when the condition is true" This reverts commit b60eafdbb8e2ebee8eed4475008e6fbb4fc5fa0b. Change-Id: Ib6e1064d0d4b0de98db47f324e5d298981522dc3 --- diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index c955e14..d297f1e 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -3453,21 +3453,23 @@ __mmplayer_gst_set_videosink_property(mmplayer_t *player, MMDisplaySurfaceType s return MM_ERROR_PLAYER_INTERNAL; } + LOGD("surface type %d, videosink factory name is %s", surface_type, factory_name); if (surface_type == MM_DISPLAY_SURFACE_OVERLAY) { bool use_tbm = (player->set_mode.video_zc || (player->is_360_feature_enabled && player->is_content_spherical)); - - if (strncmp(factory_name, "tizenwlsink", strlen(factory_name)) == 0) { - g_object_set(player->pipeline->videobin[MMPLAYER_V_SINK].gst, - "use-tbm", use_tbm, NULL); + if (!use_tbm) { + /* support shard memory with S/W codec on HawkP */ + if (strncmp(factory_name, "tizenwlsink", strlen(factory_name)) == 0) { + g_object_set(player->pipeline->videobin[MMPLAYER_V_SINK].gst, + "use-tbm", use_tbm, NULL); + } } + if (_mmplayer_update_video_overlay_param(player, "update_all_param") != MM_ERROR_NONE) return MM_ERROR_PLAYER_INTERNAL; - } else { g_object_set(G_OBJECT(player->pipeline->videobin[MMPLAYER_V_SINK].gst), "sync", TRUE, "max-lateness", FAKE_SINK_MAX_LATENESS, NULL); } - LOGD("surface type : %d, videosink factory name is %s use-tbm : %d", surface_type, factory_name, use_tbm); mm_attrs_get_int_by_name(attrs, MM_PLAYER_GAPLESS_MODE, &gapless); if (gapless > 0) {