From: Chanwoo Choi Date: Thu, 24 Apr 2014 11:15:45 +0000 (+0900) Subject: extcon: max14577: Use devm_extcon_dev_allocate for extcon_dev X-Git-Tag: v3.16-rc1~30^2~38^2~21^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0604002cde72cd60a11013daf2d9f456d4895ce8;p=platform%2Fkernel%2Flinux-exynos.git extcon: max14577: Use devm_extcon_dev_allocate for extcon_dev This patch use devm_extcon_dev_allocate() to simplify the memory control of extcon device. Cc: Krzysztof Kozlowski Signed-off-by: Chanwoo Choi Reviewed-by: Krzysztof Kozlowski Reviewed-by: Felipe Balbi --- diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c index d17dd4f..d49e891 100644 --- a/drivers/extcon/extcon-max14577.c +++ b/drivers/extcon/extcon-max14577.c @@ -739,14 +739,15 @@ static int max14577_muic_probe(struct platform_device *pdev) } /* Initialize extcon device */ - info->edev = devm_kzalloc(&pdev->dev, sizeof(*info->edev), GFP_KERNEL); - if (!info->edev) { + info->edev = devm_extcon_dev_allocate(&pdev->dev, + max14577_extcon_cable); + if (IS_ERR(info->edev)) { dev_err(&pdev->dev, "failed to allocate memory for extcon\n"); return -ENOMEM; } info->edev->name = dev_name(&pdev->dev); - info->edev->supported_cable = max14577_extcon_cable; + ret = devm_extcon_dev_register(&pdev->dev, info->edev); if (ret) { dev_err(&pdev->dev, "failed to register extcon device\n");