From: Namjae Jeon Date: Sat, 22 Dec 2012 03:09:43 +0000 (+0900) Subject: f2fs: handle error from f2fs_iget_nowait X-Git-Tag: v3.8-rc3~26^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=06025f4df88e9e41f4ebcf6b4c3df30661332bc9;p=platform%2Fkernel%2Flinux-3.10.git f2fs: handle error from f2fs_iget_nowait In case f2fs_iget_nowait returns error, it results in truncate_hole being called with 'error' value as inode pointer. There is no check in truncate_hole for valid inode, so it could result in crash due "invalid access to memory". Avoid this by handling error condition properly. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index b07e9b6..207e2c8 100644 --- a/fs/f2fs/recovery.c +++ b/fs/f2fs/recovery.c @@ -228,6 +228,9 @@ static void check_index_in_prev_nodes(struct f2fs_sb_info *sbi, /* Deallocate previous index in the node page */ inode = f2fs_iget_nowait(sbi->sb, ino); + if (IS_ERR(inode)) + return; + truncate_hole(inode, bidx, bidx + 1); iput(inode); }