From: Przemyslaw Ciezkowski
Date: Wed, 24 Jun 2015 10:02:02 +0000 (+0200)
Subject: [TVAudio] Retrieve audio output mode
X-Git-Tag: submit/tizen/20150702.103311^2~2^2~13
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=05da15598b5e67c13e5714b72082d6da0319acea;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git
[TVAudio] Retrieve audio output mode
Added reference. Added better error handling.
[Verification]
TCT pass:
AudioControlManager_getOutputMode
AudioControlManager_getOutputMode_extra_argument
Change-Id: Ib3590e783fe7b1456cdbf360822b4d03621efa2b
Signed-off-by: Przemyslaw Ciezkowski
---
diff --git a/src/tvaudio/tvaudio_instance.cc b/src/tvaudio/tvaudio_instance.cc
index e9a2fda6..bcf1b061 100644
--- a/src/tvaudio/tvaudio_instance.cc
+++ b/src/tvaudio/tvaudio_instance.cc
@@ -155,8 +155,12 @@ void TVAudioInstance::getOutputMode(const picojson::value& args,
if (result.IsError()) {
LoggerD("Error occured");
ReportError(result, &out);
+ } else if (AudioOutputModeMap.find(mode) == AudioOutputModeMap.end()) {
+ LoggerE("Unknown mode type: %d", mode);
+ ReportError(common::PlatformResult(common::ErrorCode::UNKNOWN_ERR,
+ "Uknown audio output mode"), &out);
} else {
- ReportSuccess(picojson::value(AudioOutputModeMap.at(mode)), out);
+ ReportSuccess(picojson::value(AudioOutputModeMap.at(mode)), out);
}
}
diff --git a/src/tvaudio/tvaudio_manager.cc b/src/tvaudio/tvaudio_manager.cc
index 0012b440..6c5e5304 100755
--- a/src/tvaudio/tvaudio_manager.cc
+++ b/src/tvaudio/tvaudio_manager.cc
@@ -164,7 +164,7 @@ common::PlatformResult AudioControlManager::getVolume(u_int16_t &volume) {
return common::PlatformResult(ErrorCode::NO_ERROR);
}
-common::PlatformResult AudioControlManager::getOutputMode(AudioOutputMode mode) {
+common::PlatformResult AudioControlManager::getOutputMode(AudioOutputMode &mode) {
LoggerD("Enter");
avoc_audio_format_e type;
int ret = avoc_get_audio_format(&type);
diff --git a/src/tvaudio/tvaudio_manager.h b/src/tvaudio/tvaudio_manager.h
index 434d50c5..3683e463 100755
--- a/src/tvaudio/tvaudio_manager.h
+++ b/src/tvaudio/tvaudio_manager.h
@@ -53,7 +53,7 @@ class AudioControlManager {
common::PlatformResult setVolumeDown();
common::PlatformResult playSound(const std::string &type);
common::PlatformResult getVolume(u_int16_t &volume);
- common::PlatformResult getOutputMode(AudioOutputMode mode);
+ common::PlatformResult getOutputMode(AudioOutputMode &mode);
common::PlatformResult registerVolumeChangeListener(VolumeChangeListener* listener);
common::PlatformResult unregisterVolumeChangeListener();
static void volumeChangeCallback(unsigned int volume, void* user_data);