From: Ed Bartosh <eduard.bartosh@intel.com>
Date: Wed, 2 Apr 2014 06:25:46 +0000 (+0300)
Subject: Minor refactoring of get_status
X-Git-Tag: 0.2~22
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=05d66834c49161b1c2202bd3d41c138294ceff3f;p=tools%2Frepa.git

Minor refactoring of get_status

Change-Id: Ia5f5e02b9231d11c85b884be9c7c64c64bbfed11
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
---

diff --git a/repa/list.py b/repa/list.py
index 99620ab..0979662 100755
--- a/repa/list.py
+++ b/repa/list.py
@@ -46,20 +46,22 @@ def get_status(meta, build_results=None):
             codes.add(target.get('state'))
             for pkginfo in target['packages']:
                 codes.add(pkginfo[1])
-        if 'broken' in codes:
-            return 'broken source'
-        if 'unresolvable' in codes:
-            return 'unresolvable packages'
-        if 'failed' in codes:
-            return 'package build failed'
-        if 'building' in codes:
-            return 'package building'
+
+        statuses = [('broken', 'broken source'),
+                    ('unresolvable', 'unresolvable packages'),
+                    ('failed', 'package build failed'),
+                    ('building', 'package building')]
+        for pkgstatus, status in statuses:
+            if pkgstatus in codes:
+                return status
+
     if 'images' in meta:
         for img in meta['images']:
-            if img['status'] == 'failed':
-                return 'image build failed'
-            if img['status'] == 'building':
-                return 'image building'
+            statuses = [('failed', 'image build failed'),
+                        ('building', 'image building')]
+            for imgstatus, status in statuses:
+                if img['status'] == imgstatus:
+                    return status
     return 'ready'