From: Uwe Kleine-König Date: Thu, 9 Feb 2012 21:21:45 +0000 (+0100) Subject: spi/gpio: start with CS non-active X-Git-Tag: upstream/snapshot3+hdmi~6968^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=05644147064acabb8587c4cbd690047494f7b3a1;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git spi/gpio: start with CS non-active The chip select line was configured as output with the initial value being active explicitly. It was later deasserted during spi_bitbang_setup() without any clock activity in between. So it makes no sense to activate the device at all and the chip select line can better start non-active. Signed-off-by: Uwe Kleine-König Acked-by: Linus Walleij Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c index 0094c64..0b56cfc 100644 --- a/drivers/spi/spi-gpio.c +++ b/drivers/spi/spi-gpio.c @@ -235,7 +235,8 @@ static int spi_gpio_setup(struct spi_device *spi) status = gpio_request(cs, dev_name(&spi->dev)); if (status) return status; - status = gpio_direction_output(cs, spi->mode & SPI_CS_HIGH); + status = gpio_direction_output(cs, + !(spi->mode & SPI_CS_HIGH)); } } if (!status)