From: sangrae.kim Date: Thu, 29 Sep 2016 04:06:08 +0000 (+0900) Subject: [convergence] Fix bug listener method name add,remove->set,unset X-Git-Tag: submit/tizen/20160929.043944~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0555dc4a379a195c455a08c5dc5bb866ba3fa276;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git [convergence] Fix bug listener method name add,remove->set,unset Change-Id: Iafde157f24c2f4d14ca332896953c29a846b2c81 Signed-off-by: sangrae.kim --- diff --git a/src/convergence/convergence_api.js b/src/convergence/convergence_api.js index e570e070..dd7be5c0 100644 --- a/src/convergence/convergence_api.js +++ b/src/convergence/convergence_api.js @@ -737,8 +737,8 @@ AppCommunicationService.prototype.send = function(channel, payload, successCallb throw native_.getErrorObject(result); }; -AppCommunicationService.prototype.addListener = function(listenerCallback) { - console.log('Entered AppCommunicationService.addListener()'); +AppCommunicationService.prototype.setListener = function(listenerCallback) { + console.log('Entered AppCommunicationService.setListener()'); var args = validator_.validateArgs(arguments, [ {name: 'listenerCallback', type: types_.FUNCTION} ]); @@ -753,7 +753,7 @@ AppCommunicationService.prototype.addListener = function(listenerCallback) { console.log('AppCommunicationServiceCommandListeners ADDED [' + lid + ']'); console.log(''); - var result = native_.callSync('AppCommunicationService_addListener', { + var result = native_.callSync('AppCommunicationService_setListener', { deviceId: this._deviceId, curListenerId: lid }); @@ -763,13 +763,13 @@ AppCommunicationService.prototype.addListener = function(listenerCallback) { return args.curListenerId; // TODO return proper index of listener }; -AppCommunicationService.prototype.removeListener = function(id) { - console.log('Entered AppCommunicationService.removeListener()'); +AppCommunicationService.prototype.unsetListener = function(id) { + console.log('Entered AppCommunicationService.unsetListener()'); var args = validator_.validateArgs(arguments, [ {name: 'id', type: types_.LONG, optional: false} ]); - var result = native_.callSync('AppCommunicationService_removeListener', { + var result = native_.callSync('AppCommunicationService_unsetListener', { deviceId: this._deviceId //curListenerId: id // not needed in below layers }); diff --git a/src/convergence/convergence_instance.cc b/src/convergence/convergence_instance.cc index 48b589b6..e4221b28 100644 --- a/src/convergence/convergence_instance.cc +++ b/src/convergence/convergence_instance.cc @@ -67,8 +67,8 @@ ConvergenceInstance::ConvergenceInstance() { REGISTER_SYNC("ConvergenceManager_stopDiscovery", ConvergenceManagerStopDiscovery); - REGISTER_SYNC("AppCommunicationService_addListener", AppCommunicationServiceAddListener); - REGISTER_SYNC("AppCommunicationService_removeListener", AppCommunicationServiceRemoveListener); + REGISTER_SYNC("AppCommunicationService_setListener", AppCommunicationServiceSetListener); + REGISTER_SYNC("AppCommunicationService_unsetListener", AppCommunicationServiceUnsetListener); //REGISTER_SYNC("Service_createLocalService", ServiceCreateLocal); #undef REGISTER_SYNC #define REGISTER_ASYNC(c,x) \ @@ -509,7 +509,7 @@ void ConvergenceInstance::AppCommunicationServiceStop( ReportSuccess(out); } -void ConvergenceInstance::AppCommunicationServiceAddListener( +void ConvergenceInstance::AppCommunicationServiceSetListener( const picojson::value& args, picojson::object& out) { ScopeLogger(); @@ -537,7 +537,7 @@ void ConvergenceInstance::AppCommunicationServiceAddListener( ReportSuccess(out); } -void ConvergenceInstance::AppCommunicationServiceRemoveListener( +void ConvergenceInstance::AppCommunicationServiceUnsetListener( const picojson::value& args, picojson::object& out) { ScopeLogger(); diff --git a/src/convergence/convergence_instance.h b/src/convergence/convergence_instance.h index b38f631a..cd0ead66 100644 --- a/src/convergence/convergence_instance.h +++ b/src/convergence/convergence_instance.h @@ -70,8 +70,8 @@ class ConvergenceInstance : public common::ParsedInstance { void AppCommunicationServiceStart(const picojson::value& args, picojson::object& out); void AppCommunicationServiceStop(const picojson::value& args, picojson::object& out); void AppCommunicationServiceSend(const picojson::value& args, picojson::object& out); - void AppCommunicationServiceAddListener(const picojson::value& args, picojson::object& out); - void AppCommunicationServiceRemoveListener(const picojson::value& args, picojson::object& out); + void AppCommunicationServiceSetListener(const picojson::value& args, picojson::object& out); + void AppCommunicationServiceUnsetListener(const picojson::value& args, picojson::object& out); // App Communication Server Service void AppCommunicationServerServiceConstructLocal(const picojson::value& args, picojson::object& out);