From: Mark Brown Date: Fri, 24 Feb 2023 14:03:57 +0000 (+0000) Subject: ASoC: mt8192: Report an error if when an invalid sidetone gain is written X-Git-Tag: v6.6.7~3340^2~4^2~5^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=05437a91173b8780692ac35313f98cac68be7c42;p=platform%2Fkernel%2Flinux-starfive.git ASoC: mt8192: Report an error if when an invalid sidetone gain is written Reporting an error on invalid values is optional but helpful to userspace so do so. Reviewed-by: Nícolas F. R. A. Prado Tested-by: Nícolas F. R. A. Prado Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20230223-asoc-mt8192-quick-fixes-v1-3-9a85f90368e1@kernel.org Signed-off-by: Mark Brown --- diff --git a/sound/soc/mediatek/mt8192/mt8192-dai-adda.c b/sound/soc/mediatek/mt8192/mt8192-dai-adda.c index a33d1ce..a02a297 100644 --- a/sound/soc/mediatek/mt8192/mt8192-dai-adda.c +++ b/sound/soc/mediatek/mt8192/mt8192-dai-adda.c @@ -601,6 +601,8 @@ static int stf_positive_gain_set(struct snd_kcontrol *kcontrol, POSITIVE_GAIN_MASK_SFT, (gain_db / 6) << POSITIVE_GAIN_SFT, &change); + } else { + return -EINVAL; } return change;