From: Pavel Labath <pavel@labath.sk>
Date: Thu, 9 Jan 2020 09:14:30 +0000 (+0100)
Subject: [DWARFDebugLoc] Tweak error message when resolving offset pairs with no base address
X-Git-Tag: llvmorg-11-init~591
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0541a9d4e7f85c1f08f27fe0c0cae293bbb3903a;p=platform%2Fupstream%2Fllvm.git

[DWARFDebugLoc] Tweak error message when resolving offset pairs with no base address

The previous message mentioned DW_LLE_offset_pair, but this is
incorrect/confusing because we can get this message even with DWARF4
(which does not use DW_LLE encodings). This happens because DWARF<=4
location entries are "upgraded" to DWARF v5 during parsing.

The new error message refrains from referencing specific constants.
Fixes pr44482.
---

diff --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
index 8aed9ab..0c5f9a9 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
@@ -79,9 +79,9 @@ DWARFLocationInterpreter::Interpret(const DWARFLocationEntry &E) {
   }
   case dwarf::DW_LLE_offset_pair: {
     if (!Base) {
-      return createStringError(
-          inconvertibleErrorCode(),
-          "Unable to resolve DW_LLE_offset_pair: base address unknown");
+      return createStringError(inconvertibleErrorCode(),
+                               "Unable to resolve location list offset pair: "
+                               "Base address not defined");
     }
     DWARFAddressRange Range{Base->Address + E.Value0, Base->Address + E.Value1,
                             Base->SectionIndex};