From: Karl Williamson Date: Thu, 6 Feb 2014 17:48:57 +0000 (-0700) Subject: t/run/locale.t: Rmv test that isn't generally valid X-Git-Tag: upstream/5.20.0~467 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=04ab80978986f51bdde4a5e2734d7172e262f54a;p=platform%2Fupstream%2Fperl.git t/run/locale.t: Rmv test that isn't generally valid The return from setlocale() on a new locale is documented in Linux as opaque, even though the Linux smokers we have return the name of the new locale. It turns out that VMS actually does return something different, and this test fails there. So, the test is testing for something that just happens to be currently true on many of our systems; hence isn't general, and hence shouldn't be tested for. And, the test isn't necessary, as we can infer from the other tests in the file that a locale passed via the environment actually takes hold, as we do so for a locale which has a comma radix, and test that the radix is correctly set. --- diff --git a/t/run/locale.t b/t/run/locale.t index 27535e6..6e98526 100644 --- a/t/run/locale.t +++ b/t/run/locale.t @@ -200,18 +200,6 @@ EOF "No compile error on v-strings when setting the locale to non-dot radix at compile time when default environment has non-dot radix"); } - for ($different) { - local $ENV{LC_NUMERIC} = $_; - local $ENV{LC_ALL}; # so it never overrides LC_NUMERIC - fresh_perl_is(<<"EOF", - use POSIX qw(locale_h); - - BEGIN { print setlocale(LC_NUMERIC), "\n"; }; -EOF - $_, { }, - "Passed in LC_NUMERIC is valid at compilation time"); - } - unless ($comma) { skip("no locale available where LC_NUMERIC is a comma", 2); } @@ -282,4 +270,4 @@ EOF } # SKIP -sub last { 17 } +sub last { 16 }