From: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Date: Tue, 16 Aug 2022 12:45:46 +0000 (+0200)
Subject: va: gst_va_create_raw_caps_from_config() may return NULL.
X-Git-Tag: 1.22.0~1083
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0446e35a14cf63233b2b4c1fcfa0f787bbf282d5;p=platform%2Fupstream%2Fgstreamer.git

va: gst_va_create_raw_caps_from_config() may return NULL.

This patch verifies if the function returns NULL in the caller.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2899>
---

diff --git a/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c b/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c
index 8948dd3..2917759 100644
--- a/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c
+++ b/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c
@@ -415,6 +415,10 @@ gst_va_decoder_get_srcpad_caps (GstVaDecoder * self)
   if (gst_va_decoder_is_open (self)) {
     srcpad_caps = gst_va_create_raw_caps_from_config (self->display,
         self->config);
+    if (!srcpad_caps) {
+      GST_WARNING_OBJECT (self, "Invalid configuration caps");
+      return NULL;
+    }
     gst_caps_replace (&self->srcpad_caps, srcpad_caps);
     gst_caps_unref (srcpad_caps);
 
diff --git a/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c b/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c
index 19d96c1..e5b7afe 100644
--- a/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c
+++ b/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c
@@ -898,6 +898,10 @@ gst_va_encoder_get_sinkpad_caps (GstVaEncoder * self)
   if (gst_va_encoder_is_open (self)) {
     sinkpad_caps = gst_va_create_raw_caps_from_config (self->display,
         self->config);
+    if (!sinkpad_caps) {
+      GST_WARNING_OBJECT (self, "Invalid configuration caps");
+      return NULL;
+    }
     gst_caps_replace (&self->sinkpad_caps, sinkpad_caps);
     gst_caps_unref (sinkpad_caps);