From: Andrew MacLeod <amacleod@redhat.com>
Date: Thu, 23 Mar 2023 14:28:34 +0000 (-0400)
Subject: Ranger cache dominator queries should ignore backedges.
X-Git-Tag: upstream/13.1.0~394
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0409aa5a2de9ce3164933814a4a7adc91f6acb96;p=platform%2Fupstream%2Fgcc.git

Ranger cache dominator queries should ignore backedges.

When querying dominators for cache values, ignore back edges in
read-only mode.

	PR tree-optimization/109238
	gcc/
	* gimple-range-cache.cc (ranger_cache::resolve_dom): Ignore
	predecessors which this block dominates.

	gcc/testsuite/
	* gcc.dg/pr109238.c: New.
---

diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc
index cc56fd4..6a098d8 100644
--- a/gcc/gimple-range-cache.cc
+++ b/gcc/gimple-range-cache.cc
@@ -1404,6 +1404,11 @@ ranger_cache::resolve_dom (vrange &r, tree name, basic_block bb)
   Value_Range er (TREE_TYPE (name));
   FOR_EACH_EDGE (e, ei, bb->preds)
     {
+      // If the predecessor is dominated by this block, then there is a back
+      // edge, and won't provide anything useful.  We'll actually end up with
+      // VARYING as we will not resolve this node.
+      if (dominated_by_p (CDI_DOMINATORS, e->src, bb))
+	continue;
       edge_range (er, e, name, RFD_READ_ONLY);
       r.union_ (er);
     }
diff --git a/gcc/testsuite/gcc.dg/pr109238.c b/gcc/testsuite/gcc.dg/pr109238.c
new file mode 100644
index 0000000..0cad823
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr109238.c
@@ -0,0 +1,16 @@
+/* PR tree-optimization/109238 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -Wall" } */
+
+void foo (void *) __attribute__((noreturn));
+void bar (void *);
+
+void
+baz (void *p)
+{
+  void *c = __builtin_realloc (p, 16);
+  if (c)
+    foo (c);
+  for (;;)
+    bar (__builtin_realloc (p, 8));	/* { dg-bogus "pointer 'p' may be used after '__builtin_realloc'" } */
+}