From: Jan Janssen Date: Mon, 18 Jul 2016 19:19:32 +0000 (+0200) Subject: sd-boot: Fix waiting for keyboard input (#3735) X-Git-Tag: v231~49 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=03e749af53bc6671270c300cdc5df4f2c5e0b9ae;p=platform%2Fupstream%2Fsystemd.git sd-boot: Fix waiting for keyboard input (#3735) WaitForKeyEx may never return on some UEFI systems depending on firmware, hardware configuration and the phase of the moon. Use ConIn->WaitForKey unconditionally instead. Fixes #3632 --- diff --git a/src/boot/efi/console.c b/src/boot/efi/console.c index c436f8b..2b797c9 100644 --- a/src/boot/efi/console.c +++ b/src/boot/efi/console.c @@ -93,12 +93,8 @@ EFI_STATUS console_key_read(UINT64 *key, BOOLEAN wait) { } /* wait until key is pressed */ - if (wait) { - if (TextInputEx) - uefi_call_wrapper(BS->WaitForEvent, 3, 1, &TextInputEx->WaitForKeyEx, &index); - else - uefi_call_wrapper(BS->WaitForEvent, 3, 1, &ST->ConIn->WaitForKey, &index); - } + if (wait) + uefi_call_wrapper(BS->WaitForEvent, 3, 1, &ST->ConIn->WaitForKey, &index); if (TextInputEx) { EFI_KEY_DATA keydata;