From: Benjamin Kramer Date: Mon, 27 Mar 2023 12:19:18 +0000 (+0200) Subject: [JITLink] Drop using namespace X-Git-Tag: upstream/17.0.6~13594 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=03df67e7858ef56910f6c08a95c7156ae00ef984;p=platform%2Fupstream%2Fllvm.git [JITLink] Drop using namespace I don't think these are holding their weight and cause nasty to debug compiler issues with some versions of MSVC as seen in https://reviews.llvm.org/D144083#4220866 Just qualify the types with the full name. --- diff --git a/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp b/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp index 9f22ad5..28fa0b6 100644 --- a/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp +++ b/llvm/lib/ExecutionEngine/JITLink/aarch32.cpp @@ -25,9 +25,6 @@ namespace llvm { namespace jitlink { namespace aarch32 { -using namespace support; -using namespace support::endian; - /// Encode 22-bit immediate value for branch instructions without J1J2 range /// extension (formats B T4, BL T1 and BLX T2). /// @@ -194,8 +191,8 @@ void writeImmediate(WritableThumbRelocation &R, HalfWords Imm) { } Expected readAddendData(LinkGraph &G, Block &B, const Edge &E) { - endianness Endian = G.getEndianness(); - assert(Endian != native && "Declare as little or big explicitly"); + support::endianness Endian = G.getEndianness(); + assert(Endian != support::native && "Declare as little or big explicitly"); Edge::Kind Kind = E.getKind(); const char *BlockWorkingMem = B.getContent().data(); @@ -203,8 +200,7 @@ Expected readAddendData(LinkGraph &G, Block &B, const Edge &E) { switch (Kind) { case Data_Delta32: - return SignExtend64<32>((Endian == little) ? read32(FixupPtr) - : read32(FixupPtr)); + return SignExtend64<32>(support::endian::read32(FixupPtr, Endian)); default: return make_error( "In graph " + G.getName() + ", section " + B.getSection().getName() +