From: Jason Ekstrand Date: Wed, 1 Mar 2017 01:15:04 +0000 (-0800) Subject: i965: Don't use MAX_SURFACES in mark_surface_used X-Git-Tag: upstream/17.1.0~1831 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=035616cb8edef47d9d2aac78d47c99563fd5468f;p=platform%2Fupstream%2Fmesa.git i965: Don't use MAX_SURFACES in mark_surface_used Vulkan doesn't respect MAX_SURFACES so this assert isn't valid in that case. It should, however, assert that it isn't insanely large. Reviewed-by: Kenneth Graunke --- diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 02aa0b2..8b852d5 100644 --- a/src/mesa/drivers/dri/i965/brw_shader.cpp +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp @@ -33,7 +33,10 @@ extern "C" void brw_mark_surface_used(struct brw_stage_prog_data *prog_data, unsigned surf_index) { - assert(surf_index < BRW_MAX_SURFACES); + /* A binding table index is 8 bits and the top 3 values are reserved for + * special things (stateless and SLM). + */ + assert(surf_index <= 252); prog_data->binding_table.size_bytes = MAX2(prog_data->binding_table.size_bytes, (surf_index + 1) * 4);