From: tranthanhtung2001 <tran.tung@samsung.com>
Date: Tue, 16 Jul 2024 04:20:29 +0000 (+0700)
Subject: Fix all tests case FAIL for file privilege_db_manager.c in privilege checker module
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=03489a44236997f771ca5ece538f4e6df95581fa;p=platform%2Fcore%2Fsecurity%2Fprivilege-checker.git

Fix all tests case FAIL for file privilege_db_manager.c in privilege checker module

Change-Id: I876132d0df3613e994aec610cea6e69ac09dae84
Signed-off-by: tranthanhtung2001 <tran.tung@samsung.com>
---

diff --git a/test/tc-privilege-db-manager.c b/test/tc-privilege-db-manager.c
index fb2c1f9..2c812d8 100644
--- a/test/tc-privilege-db-manager.c
+++ b/test/tc-privilege-db-manager.c
@@ -472,61 +472,37 @@ void __test_privilege_db_manager_is_privacy_white_list()
 	int ret = 0;
 
 	__print_line();
+	__tcinfo(goal, POS_TC_PREFIX "is privacy white list");
+
 	printf("pkgid: ise-default\n");
 	printf("privilege: http://tizen.org/privilege/call => privacy ID: 3\n");
 	printf("is privacy whitelist\n");
+
 	ret = privilege_db_manager_is_privacy_white_list("ise-default", 3);
-	printf("ret = %d\n", ret);
-	if ((ENABLE_ASKUSER && ret == 1) || (DISABLE_ASKUSER && ret == PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT)) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
+
+	__check_the_return_code('n', 1, ret);
 
 	__print_line();
+	__tcinfo(goal, NEG_TC_PREFIX "is not privacy white list");
+
 	printf("pkgid: ise-default\n");
 	printf("privilege: http://tizen.org/privilege/location => privacy ID: 7\n");
 	printf("is not privacy whitelist\n");
+
 	ret = privilege_db_manager_is_privacy_white_list("ise-default", 7);
-	printf("ret = %d\n", ret);
-	if ((ENABLE_ASKUSER && ret == 0) || (DISABLE_ASKUSER && ret == PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT)) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
 
-	__print_line();
-	printf("pkgid: ise-default\n");
-	printf("privilege: http://tizen.org/privilege/calendar.read => privacy ID: 2\n");
-	printf("is privacy whitelist\n");
-	ret = privilege_db_manager_is_privacy_white_list("ise-default", 2);
-	printf("ret = %d\n", ret);
-	if ((ENABLE_ASKUSER && ret == 1) || (DISABLE_ASKUSER && ret == PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT)) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
+	__check_the_return_code('n', 0, ret);
 
 	__print_line();
+	__tcinfo(goal, NEG_TC_PREFIX "is not privacy white list with pkgid dont exist");
+
 	printf("pkgid: orxxxxx\n");
 	printf("privilege: http://tizen.org/privilege/call => privacy ID: 3\n");
 	printf("is not privacy whitelist\n");
+
 	ret = privilege_db_manager_is_privacy_white_list("orxxxxx", 3);
-	printf("ret = %d\n", ret);
-	if ((ENABLE_ASKUSER && ret == 0) || (DISABLE_ASKUSER && ret == PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT)) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
 
+	__check_the_return_code('n', 0, ret);
 }
 
 void __test_privilege_db_manager_get_privacy_id()
@@ -563,63 +539,48 @@ void __test_privilege_db_manager_is_user_settable()
 	int ret = 0;
 
 	__print_line();
-	printf("pkgid: ise-default\n");
-	printf("privilege: http://tizen.org/privacy/calendar => privacy ID: 2\n");
-	printf("is not user-settable\n");
-	ret = privilege_db_manager_is_user_settable("ise-default", 2);
-	printf("ret = %d\n", ret);
-	if ((ENABLE_ASKUSER && ret == 0) || (DISABLE_ASKUSER && ret == 1)) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
+	__tcinfo(goal, POS_TC_PREFIX "is user settable with arguments are valid");
 
-	__print_line();
 	printf("pkgid: ise-default\n");
 	printf("privilege: http://tizen.org/privacy/location => privacy ID: 7\n");
 	printf("is user-settable\n");
+
 	ret = privilege_db_manager_is_user_settable("ise-default", 7);
-	printf("ret = %d\n", ret);
-	if (ret == 1) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
+
+	__check_the_return_code('n', 1, ret);
+
+	__print_line();
+	__tcinfo(goal, NEG_TC_PREFIX "is not user settable with arguments are valid pkgid");
+
+	printf("pkgid: ise-default\n");
+	printf("privilege: http://tizen.org/privacy/calendar => privacy ID: 2\n");
+	printf("is not user-settable\n");
+
+	ret = privilege_db_manager_is_user_settable("ise-default", 2);
+
+	__check_the_return_code('n', 0, ret);
 
 	__print_line();
+	__tcinfo(goal, NEG_TC_PREFIX "is user settable with arguments are invalid pkgid");
+
 	printf("pkgid: org.tizen.xxxxxxx\n");
 	printf("privilege: http://tizen.org/privacy/location => privacy ID: 7\n");
 	printf("is user-settable\n");
+
 	ret = privilege_db_manager_is_user_settable("org.tizen.xxxxxxx", 7);
-	printf("ret = %d\n", ret);
-	if (ret == 1) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
+
+	__check_the_return_code('n', 1, ret);
 
 	__print_line();
+	__tcinfo(goal, NEG_TC_PREFIX "is user settable with arguments are invalid privacy_id");
+
 	printf("pkgid: org.tizen.xxxxxxx\n");
 	printf("privilege: http://tizen.org/privacy/xxxxx\n");
 	printf("is user-settable\n");
+
 	ret = privilege_db_manager_is_user_settable("org.tizen.xxxxxxx", -1);
-	if (ret < 0)
-		printf("ret = %s\n", __get_result_string('d', ret));
-	else
-		printf("ret = %d\n", ret);
-	if (ret == PRIVILEGE_DB_MANAGER_ERR_INVALID_PARAMETER) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("fail\n");
-	}
+
+	__check_the_return_code('d', PRIVILEGE_DB_MANAGER_ERR_INVALID_PARAMETER, ret);
 
 	__print_line();
 }
@@ -628,72 +589,37 @@ void __test_privilege_db_manager_get_same_privacy_grouped_privileges()
 {
 	int ret = 0;
 	GList *privilege_list = NULL;
+	GList *expected_list = NULL;
+	char *element1 = "http://tizen.org/privilege/account.read";
+	char *element2 = "http://tizen.org/privilege/account.write";
+
+	expected_list = g_list_append(expected_list, element1);
+	expected_list = g_list_append(expected_list, element2);
 
 	__print_line();
-	printf("privilege = http://tizen.org/privilege/account.read\n");
-	ret = privilege_db_manager_get_same_privacy_grouped_privileges("http://tizen.org/privilege/account.read", &privilege_list);
+	__tcinfo(goal, POS_TC_PREFIX "get same privacy grouped privileges");
 
-	if (ENABLE_ASKUSER) {
-		printf("privacy = account\n");
-		if (ret == PRIVILEGE_DB_MANAGER_ERR_NONE && privilege_list != NULL) {
-			success_cnt++;
-			printf_green("success\n");
-		} else {
-			fail_cnt++;
-			printf_red("failed. ret = %s\n", __get_result_string('m', ret));
-		}
-	} else {
-		printf("not privacy\n");
-		if (ret == PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT && privilege_list == NULL) {
-			success_cnt++;
-			printf_green("success\n");
-		} else {
-			fail_cnt++;
-			printf_red("failed. ret = %s\n", __get_result_string('d', ret));
-		}
-	}
+	printf("privilege = %s\n", element1);
 
-	if (privilege_list != NULL) {
-		__print_glist(privilege_list);
-		g_list_free_full(privilege_list, free);
-		privilege_list = NULL;
-	}
+	ret = privilege_db_manager_get_same_privacy_grouped_privileges(element1, &privilege_list);
 
-	__print_line();
-	printf("privilege = http://tizen.org/privilege/internet\n");
-	printf("not privacy\n");
+	__check_result_code_and_list(expected_list, privilege_list, PRIVILEGE_DB_MANAGER_ERR_NONE, ret, true, 'd');
 
-	ret = privilege_db_manager_get_same_privacy_grouped_privileges("http://tizen.org/privilege/internet", &privilege_list);
-	if (ret == PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT && privilege_list == NULL) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("failed. internet privilege is not privacy. ret = %s\n", __get_result_string('d', ret));
-	}
+	g_list_free_full(privilege_list, free);
+	privilege_list = NULL;
+	expected_list = NULL;
+	element1 = "http://tizen.org/privilege/internet";
 
-	if (privilege_list != NULL) {
-		__print_glist(privilege_list);
-		g_list_free_full(privilege_list, free);
-		privilege_list = NULL;
-	}
 	__print_line();
-	printf("privilege = http://tizen.org/privilege/internal/buxton/message.read\n");
-	printf("not privacy\n");
+	__tcinfo(goal, NEG_TC_PREFIX "get same privacy grouped privileges no exist result");
 
-	ret = privilege_db_manager_get_same_privacy_grouped_privileges("http://tizen.org/privilege/internal/buxton/message.read", &privilege_list);
-	if (ret == PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT && privilege_list == NULL) {
-		success_cnt++;
-		printf_green("success\n");
-	} else {
-		fail_cnt++;
-		printf_red("failed. internal/buxton/message.read privilege is not privacy. ret = %s\n", __get_result_string('d', ret));
-	}
+	printf("privilege = %s\n", element1);
 
-	if (privilege_list != NULL) {
-		__print_glist(privilege_list);
-		g_list_free_full(privilege_list, free);
-	}
+	ret = privilege_db_manager_get_same_privacy_grouped_privileges(element1, &privilege_list);
+
+	__check_result_code_and_list(expected_list, privilege_list, PRIVILEGE_DB_MANAGER_ERR_NO_EXIST_RESULT, ret, true, 'd');
+
+	privilege_list = NULL;
 }
 
 void __test_privilege_db_manager_set_package_privacy_privilege_info()