From: Inkyun Kil <inkyun.kil@samsung.com>
Date: Mon, 5 Feb 2018 04:21:10 +0000 (+0900)
Subject: Remove needless codes
X-Git-Tag: submit/tizen_4.0/20180313.002146~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=033f49b4ef644dfebd8959f9533cd202c2d24f84;p=platform%2Fcore%2Fappfw%2Falarm-manager.git

Remove needless codes

Change-Id: I689c2f1adae614d471cad7c60bc7366f15b8801d
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
---

diff --git a/alarm-manager.c b/alarm-manager.c
index 551a182..043027c 100644
--- a/alarm-manager.c
+++ b/alarm-manager.c
@@ -127,7 +127,7 @@ static bool is_db_corrupted = false;
 
 static int __is_ui_app(const char *appid, uid_t uid);
 static long __get_proper_interval(long interval, int alarm_type);
-static bool __alarm_add_to_list(__alarm_info_t *__alarm_info);
+static void __alarm_add_to_list(__alarm_info_t *__alarm_info);
 static void __alarm_generate_alarm_id(__alarm_info_t *__alarm_info, alarm_id_t *alarm_id);
 static __alarm_info_t *__alarm_update_in_list(int uid, alarm_id_t alarm_id,
 		alarm_info_t *alarm_info, int update_flag, int *error_code);
@@ -485,7 +485,7 @@ static void __alarm_generate_alarm_id(__alarm_info_t *__alarm_info, alarm_id_t *
 	return;
 }
 
-static bool __alarm_add_to_list(__alarm_info_t *__alarm_info)
+static void __alarm_add_to_list(__alarm_info_t *__alarm_info)
 {
 	alarm_info_t *alarm_info = &__alarm_info->alarm_info;
 	__alarm_info_t *entry = NULL;
@@ -506,8 +506,6 @@ static bool __alarm_add_to_list(__alarm_info_t *__alarm_info)
 		if (!_save_alarms(__alarm_info))
 			ALARM_MGR_EXCEPTION_PRINT("Saving alarm_id(%d) in DB is failed.", __alarm_info->alarm_id);
 	}
-
-	return true;
 }
 
 static bool __check_bundle_for_update(const gchar *b_data, uid_t uid)
@@ -942,11 +940,7 @@ static bool __alarm_create_appsvc(alarm_info_t *alarm_info, alarm_id_t *alarm_id
 	}
 
 	due_time = _alarm_next_duetime(__alarm_info);
-	if (__alarm_add_to_list(__alarm_info) == false) {
-		_release_alarm_info_t(__alarm_info);
-		*error_code = ERR_ALARM_SYSTEM_FAIL;
-		return false;
-	}
+	__alarm_add_to_list(__alarm_info);
 
 	if (due_time == 0) {
 		ALARM_MGR_EXCEPTION_PRINT("[alarm-server]:Create a new alarm: "
@@ -1063,10 +1057,7 @@ static bool __alarm_create(alarm_info_t *alarm_info, alarm_id_t *alarm_id, uid_t
 	}
 
 	due_time = _alarm_next_duetime(__alarm_info);
-	if (__alarm_add_to_list(__alarm_info) == false) {
-		_release_alarm_info_t(__alarm_info);
-		return false;
-	}
+	__alarm_add_to_list(__alarm_info);
 
 	if (due_time == 0) {
 		ALARM_MGR_EXCEPTION_PRINT("[alarm-server]:Create a new alarm: due_time is 0, alarm(%d).", *alarm_id);
@@ -1172,10 +1163,7 @@ static bool __alarm_create_noti(alarm_info_t *alarm_info, alarm_id_t *alarm_id,
 	}
 
 	due_time = _alarm_next_duetime(__alarm_info);
-	if (__alarm_add_to_list(__alarm_info) == false) {
-		_release_alarm_info_t(__alarm_info);
-		return false;
-	}
+	__alarm_add_to_list(__alarm_info);
 
 	if (due_time == 0) {
 		ALARM_MGR_EXCEPTION_PRINT("[alarm-server]:Create a new alarm: due_time is 0, alarm(%d).", *alarm_id);