From: 오형석/동작제어Lab(SR)/Staff Engineer/삼성전자 <hseok82.oh@samsung.com>
Date: Mon, 10 Sep 2018 04:21:19 +0000 (+0900)
Subject: Set umask for temp file generation (#2637)
X-Git-Tag: 0.2~54
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=033e78e80ce2d6feb2aaabbe389127b16c51d15c;p=platform%2Fcore%2Fml%2Fnnfw.git

Set umask for temp file generation (#2637)

Set umask and recover after generate temporary file to avoid security issue

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
---

diff --git a/runtimes/tests/neural_networks_test/TestValidation.cpp b/runtimes/tests/neural_networks_test/TestValidation.cpp
index 3061f96..e4f287a 100644
--- a/runtimes/tests/neural_networks_test/TestValidation.cpp
+++ b/runtimes/tests/neural_networks_test/TestValidation.cpp
@@ -33,7 +33,12 @@ static int shmem_create_region(size_t size)
 {
     char temp[PATH_MAX];
     snprintf(temp, sizeof(temp), "/tmp/nn-shmem-%d-%d-XXXXXXXXX", getpid(), shmem_num++);
+
+    // Set umask and recover after generate temporary file to avoid security issue
+    mode_t umaskPrev = umask(S_IRUSR|S_IWUSR);
     int fd = mkstemp(temp);
+    umask(umaskPrev);
+
     if (fd == -1) return -1;
 
     unlink(temp);