From: YueHaibing Date: Sat, 2 Nov 2019 07:57:44 +0000 (+0800) Subject: gpu: host1x: Remove dev_err() on platform_get_irq() failure X-Git-Tag: v5.15~4520^2~2^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=033ccdb7f6b11701623507339646013b4ce389d3;p=platform%2Fkernel%2Flinux-starfive.git gpu: host1x: Remove dev_err() on platform_get_irq() failure platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: YueHaibing Signed-off-by: Thierry Reding --- diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c index a738ea5..388bcc2 100644 --- a/drivers/gpu/host1x/dev.c +++ b/drivers/gpu/host1x/dev.c @@ -339,10 +339,8 @@ static int host1x_probe(struct platform_device *pdev) } syncpt_irq = platform_get_irq(pdev, 0); - if (syncpt_irq < 0) { - dev_err(&pdev->dev, "failed to get IRQ: %d\n", syncpt_irq); + if (syncpt_irq < 0) return syncpt_irq; - } mutex_init(&host->devices_lock); INIT_LIST_HEAD(&host->devices);