From: Charles Giessen <charles@lunarg.com>
Date: Mon, 3 Jul 2023 21:44:02 +0000 (-0600)
Subject: Fix wrong pointer usage
X-Git-Tag: upstream/1.3.268~75
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=031b0ef971e9e89dbb03b6cf2691394ceffb7204;p=platform%2Fupstream%2FVulkan-Loader.git

Fix wrong pointer usage

get_override_layer_override_paths logs the path used, but during the refactor it
failed to dereference the double pointer properly, leading to the loader_log
message reading garbage. This was not caught on x64 address sanitizer builds, but
was on the 32 bit build.
---

diff --git a/loader/loader.c b/loader/loader.c
index 7eb9881a..3f9034fa 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -3790,8 +3790,8 @@ VkResult get_override_layer_override_paths(struct loader_instance *inst, struct
         --cur_write_ptr;
         assert(cur_write_ptr - (*override_paths) < (ptrdiff_t)override_path_size);
         *cur_write_ptr = '\0';
-        loader_log(NULL, VULKAN_LOADER_WARN_BIT | VULKAN_LOADER_LAYER_BIT, 0, "Override layer has override paths set to %s",
-                   override_paths);
+        loader_log(inst, VULKAN_LOADER_WARN_BIT | VULKAN_LOADER_LAYER_BIT, 0, "Override layer has override paths set to %s",
+                   *override_paths);
     }
     return VK_SUCCESS;
 }