From: Aleksei Vereshchagin Date: Mon, 11 Dec 2017 17:22:35 +0000 (+0300) Subject: Remove default branch in switch block for enum so compiler can check if all enum... X-Git-Tag: submit/tizen/20180619.075036~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=02f3d0d3aa30d5c5384b5ac83f36e057f3f8590c;p=sdk%2Ftools%2Fcoreprofiler.git Remove default branch in switch block for enum so compiler can check if all enum values covered by switch --- diff --git a/src/log.h b/src/log.h index 7489069..cc5fc77 100644 --- a/src/log.h +++ b/src/log.h @@ -34,6 +34,9 @@ enum class LogLevel static inline const char *LogLevelName(LogLevel level) { + // NOTE: we expect compilation error if some of LogLevel enum values don't + // be covered by 'switch' statement. So, no 'default' label or 'return' + // statement after 'switch'. switch (level) { case LogLevel::None: @@ -52,8 +55,6 @@ static inline const char *LogLevelName(LogLevel level) return "TRACE"; case LogLevel::All: return "ALL"; - default: - return ""; } }