From: Aditya Pakki <pakki001@umn.edu>
Date: Thu, 5 Dec 2019 23:04:49 +0000 (-0600)
Subject: pppoe: remove redundant BUG_ON() check in pppoe_pernet
X-Git-Tag: v5.15~4919^2~8
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=02a896ca84874bbfcedc006303f2951dda89b298;p=platform%2Fkernel%2Flinux-starfive.git

pppoe: remove redundant BUG_ON() check in pppoe_pernet

Passing NULL to pppoe_pernet causes a crash via BUG_ON.
Dereferencing net in net_generici() also has the same effect. This patch
removes the redundant BUG_ON check on the same parameter.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index a44dd3c..d760a36 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -119,8 +119,6 @@ static inline bool stage_session(__be16 sid)
 
 static inline struct pppoe_net *pppoe_pernet(struct net *net)
 {
-	BUG_ON(!net);
-
 	return net_generic(net, pppoe_net_id);
 }