From: Dan Carpenter Date: Sat, 6 Mar 2010 01:14:09 +0000 (+0000) Subject: bridge: cleanup: remove unneed check X-Git-Tag: v2.6.34-rc2~48^2~49 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=02a780c014c40973cbe71d04cec7a24e6629995f;p=profile%2Fcommon%2Fkernel-common.git bridge: cleanup: remove unneed check We dereference "port" on the lines immediately before and immediately after the test so port should hopefully never be null here. Signed-off-by: Dan Carpenter Signed-off-by: Herbert Xu Signed-off-by: David S. Miller --- diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 2559fb5..8b25887 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -627,8 +627,8 @@ static void br_multicast_port_query_expired(unsigned long data) struct net_bridge *br = port->br; spin_lock(&br->multicast_lock); - if (port && (port->state == BR_STATE_DISABLED || - port->state == BR_STATE_BLOCKING)) + if (port->state == BR_STATE_DISABLED || + port->state == BR_STATE_BLOCKING) goto out; if (port->multicast_startup_queries_sent <