From: SeokYeon Hwang Date: Wed, 25 Jun 2014 06:14:36 +0000 (+0900) Subject: pci: add checking whether the device is realized before unlinking the capability X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.1~324 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0282e502f33227382699a8da715093e442e40348;p=sdk%2Femulator%2Fqemu.git pci: add checking whether the device is realized before unlinking the capability In case of the unrealized "pdev", memory can be illegally accessed and corrupted. Refer to device_unparent() in the commit 5c21ce77d7e5643089ceec556c0408445d017f32. Change-Id: Iacb195a092c86d4c677ad0404582af104b2251ae Signed-off-by: SeokYeon Hwang --- diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 2a9f08eb0a..cdc8ee23d9 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2056,7 +2056,11 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id, /* Unlink capability from the pci config space. */ void pci_del_capability(PCIDevice *pdev, uint8_t cap_id, uint8_t size) { - uint8_t prev, offset = pci_find_capability_list(pdev, cap_id, &prev); + uint8_t prev, offset; + if (!(pdev->qdev.realized)) { + return; + } + offset = pci_find_capability_list(pdev, cap_id, &prev); if (!offset) return; pdev->config[prev] = pdev->config[offset + PCI_CAP_LIST_NEXT];