From: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date: Thu, 24 Nov 2011 10:15:29 +0000 (+0100)
Subject: pad: Remove g_warning() if pad accepted caps that are not a subset of the pad caps
X-Git-Tag: RELEASE-0.10.36~64
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0280a3c29ffbc33665fa25ae001e91c9a44b801e;p=platform%2Fupstream%2Fgstreamer.git

pad: Remove g_warning() if pad accepted caps that are not a subset of the pad caps

This check is correct but unfortunately it's impossible to implement
in a threadsafe way because the caps could have changed in the meantime.

Fixes bug #659606.
---

diff --git a/gst/gstpad.c b/gst/gstpad.c
index 01937e6..206c545 100644
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -2630,26 +2630,6 @@ gst_pad_accept_caps (GstPad * pad, GstCaps * caps)
     GST_DEBUG_OBJECT (pad, "default acceptcaps returned %d", result);
   }
 
-#ifndef G_DISABLE_ASSERT
-  if (result) {
-    GstCaps *padcaps;
-
-    padcaps = gst_pad_get_caps_reffed (pad);
-    if (!gst_caps_is_subset (caps, padcaps)) {
-      gchar *padcaps_str, *caps_str;
-
-      padcaps_str = gst_caps_to_string (padcaps);
-      caps_str = gst_caps_to_string (caps);
-      g_warning ("pad %s:%s accepted caps %s although "
-          "they are not a subset of its caps %s",
-          GST_DEBUG_PAD_NAME (pad), caps_str, padcaps_str);
-      g_free (padcaps_str);
-      g_free (caps_str);
-    }
-    gst_caps_unref (padcaps);
-  }
-#endif
-
   return result;
 
 is_same_caps: