From: Wei Yongjun Date: Tue, 26 Mar 2013 07:45:11 +0000 (-0300) Subject: [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer() X-Git-Tag: v3.10-rc1~136^2~175 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=02745f63443c08b9b82ab2d654a0f5fc3699e586;p=platform%2Fupstream%2Fkernel-adaptation-pc.git [media] go7007: fix invalid use of sizeof in go7007_usb_i2c_master_xfer() sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Signed-off-by: Wei Yongjun Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c index a734ead..50066e0 100644 --- a/drivers/staging/media/go7007/go7007-usb.c +++ b/drivers/staging/media/go7007/go7007-usb.c @@ -1037,7 +1037,7 @@ static int go7007_usb_i2c_master_xfer(struct i2c_adapter *adapter, buf, buf_len, 0) < 0) goto i2c_done; if (msgs[i].flags & I2C_M_RD) { - memset(buf, 0, sizeof(buf)); + memset(buf, 0, msgs[i].len + 1); if (go7007_usb_vendor_request(go, 0x25, 0, 0, buf, msgs[i].len + 1, 1) < 0) goto i2c_done;