From: H Hartley Sweeten Date: Thu, 17 Apr 2014 17:08:01 +0000 (-0700) Subject: staging: comedi: me4000: validate the cmd->start_arg X-Git-Tag: v4.14-rc1~7083^2~39^2~1325 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=025b918731e4ee46ee8a27073281b2db715f79e2;p=platform%2Fkernel%2Flinux-rpi.git staging: comedi: me4000: validate the cmd->start_arg The cmd->start_arg should be trivially validated in Step 3 of the (*do_cmdtest) functions. Add the necessary code. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c index e146555..f43221f 100644 --- a/drivers/staging/comedi/drivers/me4000.c +++ b/drivers/staging/comedi/drivers/me4000.c @@ -918,6 +918,8 @@ static int me4000_ai_do_cmd_test(struct comedi_device *dev, /* Step 3: check if arguments are trivially valid */ + err |= cfc_check_trigger_arg_is(&cmd->start_arg, 0); + if (cmd->chanlist_len < 1) { cmd->chanlist_len = 1; err |= -EINVAL;