From: Wim Taymans <wim.taymans@collabora.co.uk>
Date: Fri, 26 Jul 2013 20:31:41 +0000 (+0200)
Subject: session: don't make buffer writable prematurely
X-Git-Tag: 1.19.3~509^2~5531
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=02359f921910f8e49dbaf45c5c87bdd9304d8d74;p=platform%2Fupstream%2Fgstreamer.git

session: don't make buffer writable prematurely

There is no reason to make the SR buffer writable at this point. This is better
delayed until needed.
---

diff --git a/gst/rtpmanager/rtpsession.c b/gst/rtpmanager/rtpsession.c
index 5bd9bc3..1ab8185 100644
--- a/gst/rtpmanager/rtpsession.c
+++ b/gst/rtpmanager/rtpsession.c
@@ -2346,9 +2346,6 @@ rtp_session_process_rtcp (RTPSession * sess, GstBuffer * buffer,
 
   /* notify caller of sr packets in the callback */
   if (do_sync && sess->callbacks.sync_rtcp) {
-    /* make writable, we might want to change the buffer */
-    buffer = gst_buffer_make_writable (buffer);
-
     result = sess->callbacks.sync_rtcp (sess, buffer,
         sess->sync_rtcp_user_data);
   } else