From: Thomas Weißschuh Date: Wed, 21 Dec 2022 17:59:51 +0000 (+0000) Subject: platform/x86: asus-wmi: Don't load fan curves without fan X-Git-Tag: v6.6.17~5766^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=01fd7e7851ba2275662f771ee17d1f80e7bbfa52;p=platform%2Fkernel%2Flinux-rpi.git platform/x86: asus-wmi: Don't load fan curves without fan If we do not have a fan it does not make sense to load curves for it. This removes the following warnings from the kernel log: asus_wmi: fan_curve_get_factory_default (0x00110024) failed: -19 asus_wmi: fan_curve_get_factory_default (0x00110025) failed: -19 Fixes: a2bdf10ce96e ("platform/x86: asus-wmi: Increase FAN_CURVE_BUF_LEN to 32") Signed-off-by: Thomas Weißschuh Link: https://lore.kernel.org/r/20221221-asus-fan-v1-3-e07f3949725b@weissschuh.net Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 4a289ca..104188d 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -2438,6 +2438,9 @@ static int fan_curve_check_present(struct asus_wmi *asus, bool *available, *available = false; + if (asus->fan_type == FAN_TYPE_NONE) + return 0; + err = fan_curve_get_factory_default(asus, fan_dev); if (err) { return 0;