From: Yicong Yang Date: Fri, 13 Dec 2019 11:44:34 +0000 (+0800) Subject: PCI/AER: Log which device prevents error recovery X-Git-Tag: v5.15~4578^2~14^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=01daacfb9035e5b86d43a01f11a0614648f306c1;p=platform%2Fkernel%2Flinux-starfive.git PCI/AER: Log which device prevents error recovery PCI error recovery will fail if any device under the Root Port doesn't have an error_detected callback. Currently only the failure result is printed, which is not enough to identify the driver that lacks the callback. Log a message to identify the device with no error_detected callback. [bhelgaas: tweak log message] Link: https://lore.kernel.org/r/1576237474-32021-1-git-send-email-yangyicong@hisilicon.com Signed-off-by: Yicong Yang Signed-off-by: Bjorn Helgaas --- diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index b0e6048..98acf94 100644 --- a/drivers/pci/pcie/err.c +++ b/drivers/pci/pcie/err.c @@ -61,10 +61,12 @@ static int report_error_detected(struct pci_dev *dev, * error callbacks of "any" device in the subtree, and will * exit in the disconnected error state. */ - if (dev->hdr_type != PCI_HEADER_TYPE_BRIDGE) + if (dev->hdr_type != PCI_HEADER_TYPE_BRIDGE) { vote = PCI_ERS_RESULT_NO_AER_DRIVER; - else + pci_info(dev, "AER: Can't recover (no error_detected callback)\n"); + } else { vote = PCI_ERS_RESULT_NONE; + } } else { err_handler = dev->driver->err_handler; vote = err_handler->error_detected(dev, state);