From: Caio Marcelo de Oliveira Filho Date: Mon, 16 Jul 2018 20:50:07 +0000 (-0700) Subject: anv: avoid warning when switching in VkStructureType X-Git-Tag: upstream/19.0.0~3754 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=01d02e8906a9bc327d257c7bccba39f6af74045f;p=platform%2Fupstream%2Fmesa.git anv: avoid warning when switching in VkStructureType When one of the cases is not part of the enum, the compilar complains: ../../src/intel/vulkan/anv_formats.c: In function ‘anv_GetPhysicalDeviceFormatProperties2’: ../../src/intel/vulkan/anv_formats.c:728:7: warning: case value ‘1000001004’ not in enumerated type ‘VkStructureType’ {aka ‘enum VkStructureType’} [-Wswitch] case VK_STRUCTURE_TYPE_WSI_FORMAT_MODIFIER_PROPERTIES_LIST_MESA: ^~~~ Given the switch has an "default:" case, we don't lose anything by switching on the unsigned value to avoid the warning. Reviewed-by: Anuj Phogat --- diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index 0c5b8d3..815b320 100644 --- a/src/intel/vulkan/anv_formats.c +++ b/src/intel/vulkan/anv_formats.c @@ -724,7 +724,8 @@ void anv_GetPhysicalDeviceFormatProperties2( &pFormatProperties->formatProperties); vk_foreach_struct(ext, pFormatProperties->pNext) { - switch (ext->sType) { + /* Use unsigned since some cases are not in the VkStructureType enum. */ + switch ((unsigned)ext->sType) { case VK_STRUCTURE_TYPE_WSI_FORMAT_MODIFIER_PROPERTIES_LIST_MESA: get_wsi_format_modifier_properties_list(physical_device, format, (void *)ext);