From: Bin Meng Date: Thu, 3 Aug 2023 09:32:41 +0000 (+0800) Subject: video: vidconsole: Fix null dereference of ops->measure X-Git-Tag: v2023.10~40^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=01c76f1a64ba8cb3da9b26be481e289ee16960f0;p=platform%2Fkernel%2Fu-boot.git video: vidconsole: Fix null dereference of ops->measure At present vidconsole_measure() tests ops->select_font before calling ops->measure, which would result in a null dereference when the console driver provides no ops for measure. Fixes: b828ed7d7929 ("console: Allow measuring the bounding box of text") Signed-off-by: Bin Meng Reviewed-by: Simon Glass --- diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vidconsole-uclass.c index 05f9304..b5b3b66 100644 --- a/drivers/video/vidconsole-uclass.c +++ b/drivers/video/vidconsole-uclass.c @@ -603,7 +603,7 @@ int vidconsole_measure(struct udevice *dev, const char *name, uint size, struct vidconsole_ops *ops = vidconsole_get_ops(dev); int ret; - if (ops->select_font) { + if (ops->measure) { ret = ops->measure(dev, name, size, text, bbox); if (ret != -ENOSYS) return ret;