From: Ido Schimmel Date: Tue, 6 Aug 2019 13:19:53 +0000 (+0300) Subject: drop_monitor: Document scope of spinlock X-Git-Tag: v5.4-rc1~131^2~296^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=01921d53f870653f04ebf8d3c375029ee3ca4a31;p=platform%2Fkernel%2Flinux-rpi.git drop_monitor: Document scope of spinlock While 'per_cpu_dm_data' is a per-CPU variable, its 'skb' and 'send_timer' fields can be accessed concurrently by the CPU sending the netlink notification to user space from the workqueue and the CPU tracing kfree_skb(). This spinlock is meant to protect against that. Document its scope and suppress the checkpatch message "spinlock_t definition without comment". Signed-off-by: Ido Schimmel Signed-off-by: David S. Miller --- diff --git a/net/core/drop_monitor.c b/net/core/drop_monitor.c index 000ec8b..35d31b0 100644 --- a/net/core/drop_monitor.c +++ b/net/core/drop_monitor.c @@ -52,7 +52,7 @@ static int trace_state = TRACE_OFF; static DEFINE_MUTEX(net_dm_mutex); struct per_cpu_dm_data { - spinlock_t lock; + spinlock_t lock; /* Protects 'skb' and 'send_timer' */ struct sk_buff *skb; struct work_struct dm_alert_work; struct timer_list send_timer;