From: Oliver Neukum <oneukum@suse.com>
Date: Thu, 12 May 2022 12:50:00 +0000 (+0100)
Subject: media: iguanair: no superfluous usb_unlink_urb()
X-Git-Tag: v6.1-rc5~729^2~406
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0189ef82722894bc8c9361f90f18577977d58ef4;p=platform%2Fkernel%2Flinux-starfive.git

media: iguanair: no superfluous usb_unlink_urb()

Unlinking yourself while the completion handler
is running is a NOP. Drop it.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---

diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index c9cb827..276bf3c 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers/media/rc/iguanair.c
@@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb)
 		return;
 
 	ir = urb->context;
-	if (!ir) {
-		usb_unlink_urb(urb);
+	if (!ir)
 		return;
-	}
 
 	switch (urb->status) {
 	case 0:
@@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb)
 	case -ECONNRESET:
 	case -ENOENT:
 	case -ESHUTDOWN:
-		usb_unlink_urb(urb);
 		return;
 	case -EPIPE:
 	default: