From: Álvaro Fernández Rojas Date: Tue, 15 Dec 2015 20:03:46 +0000 (+0100) Subject: leds: bcm6328: remove unneded lock when checking initial LED X-Git-Tag: v5.15~14455^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0171dc6abbfab4a168f65498a73d18311cb606b5;p=platform%2Fkernel%2Flinux-starfive.git leds: bcm6328: remove unneded lock when checking initial LED This lock isn't really needed, since we're only reading the register and changes made to other LEDs aren't relevant. Signed-off-by: Álvaro Fernández Rojas Signed-off-by: Jacek Anaszewski --- diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c index 1ef69c2..cd54264 100644 --- a/drivers/leds/leds-bcm6328.c +++ b/drivers/leds/leds-bcm6328.c @@ -264,7 +264,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, unsigned long *blink_leds, unsigned long *blink_delay) { struct bcm6328_led *led; - unsigned long flags; const char *state; int rc; @@ -286,7 +285,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, "linux,default-trigger", NULL); - spin_lock_irqsave(lock, flags); if (!of_property_read_string(nc, "default-state", &state)) { if (!strcmp(state, "on")) { led->cdev.brightness = LED_FULL; @@ -314,7 +312,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, } else { led->cdev.brightness = LED_OFF; } - spin_unlock_irqrestore(lock, flags); bcm6328_led_set(&led->cdev, led->cdev.brightness);