From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 25 May 2023 15:38:37 +0000 (+0300)
Subject: usb: gadget: udc: fix NULL dereference in remove()
X-Git-Tag: v6.6.7~2726^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=016da9c65fec9f0e78c4909ed9a0f2d567af6775;p=platform%2Fkernel%2Flinux-starfive.git

usb: gadget: udc: fix NULL dereference in remove()

The "udc" pointer was never set in the probe() function so it will
lead to a NULL dereference in udc_pci_remove() when we do:

	usb_del_gadget_udc(&udc->gadget);

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/ZG+A/dNpFWAlCChk@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c
index c80f9bd..a36913a 100644
--- a/drivers/usb/gadget/udc/amd5536udc_pci.c
+++ b/drivers/usb/gadget/udc/amd5536udc_pci.c
@@ -170,6 +170,9 @@ static int udc_pci_probe(
 		retval = -ENODEV;
 		goto err_probe;
 	}
+
+	udc = dev;
+
 	return 0;
 
 err_probe: