From: Jean Delvare Date: Wed, 12 Jan 2011 20:55:09 +0000 (+0100) Subject: hwmon: (w83795) Silent false warning from gcc X-Git-Tag: v2.6.38-rc1~241^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=014bcd28a04ec085940ea3125f5ea91b16a1945d;p=platform%2Fkernel%2Flinux-stable.git hwmon: (w83795) Silent false warning from gcc The code triggers a false warning with older versions of gcc: w83795.c: In function 'w83795_update_device': w83795.c:475: warning: 'lsb' may be used uninitialized in this function I admit that the code is a little tricky, but I see no way to write it differently without hurting performance. So let's just silent the warning with a needless initialization. Signed-off-by: Jean Delvare Acked-by: Guenter Roeck --- diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c index cdbc744..845232d 100644 --- a/drivers/hwmon/w83795.c +++ b/drivers/hwmon/w83795.c @@ -458,6 +458,7 @@ static void w83795_update_limits(struct i2c_client *client) { struct w83795_data *data = i2c_get_clientdata(client); int i, limit; + u8 lsb; /* Read the voltage limits */ for (i = 0; i < ARRAY_SIZE(data->in); i++) { @@ -479,9 +480,8 @@ static void w83795_update_limits(struct i2c_client *client) } /* Read the fan limits */ + lsb = 0; /* Silent false gcc warning */ for (i = 0; i < ARRAY_SIZE(data->fan); i++) { - u8 lsb; - /* Each register contains LSB for 2 fans, but we want to * read it only once to save time */ if ((i & 1) == 0 && (data->has_fan & (3 << i)))