From: Russell King Date: Thu, 8 Sep 2005 21:46:00 +0000 (+0100) Subject: [MMC] Ensure correct mmc_priv() behaviour X-Git-Tag: accepted/tizen/common/20141203.182822~43125^2~26^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=01357dcac62ac028de65a1c315eb75c530c8a5d6;p=platform%2Fkernel%2Flinux-arm64.git [MMC] Ensure correct mmc_priv() behaviour mmc_priv() has some nasty effects if the wrong pointer type is passed to it. Introduce type checking, which also means we get the right type. Also add an additional member to mmc_host which is used to align host-private data appropriately. Signed-off-by: Russell King --- diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index c5d73c0..c1f021e 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -109,6 +109,8 @@ struct mmc_host { struct mmc_card *card_selected; /* the selected MMC card */ struct work_struct detect; + + unsigned long private[0] ____cacheline_aligned; }; extern struct mmc_host *mmc_alloc_host(int extra, struct device *); @@ -116,7 +118,11 @@ extern int mmc_add_host(struct mmc_host *); extern void mmc_remove_host(struct mmc_host *); extern void mmc_free_host(struct mmc_host *); -#define mmc_priv(x) ((void *)((x) + 1)) +static inline void *mmc_priv(struct mmc_host *host) +{ + return (void *)host->private; +} + #define mmc_dev(x) ((x)->dev) #define mmc_hostname(x) ((x)->class_dev.class_id)